Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| // SENTRY_API_SCHEMA_SHA is used in the sentry-docs GHA workflow in getsentry/sentry-api-schema. | ||
| // DO NOT change variable name unless you change it in the sentry-docs GHA workflow in getsentry/sentry-api-schema. | ||
| const SENTRY_API_SCHEMA_SHA = 'd218ebe064fe5ec8cb383688e80cbf36c0a6a5e8'; | ||
| const SENTRY_API_SCHEMA_SHA = '259e6bfcd1b0e68776314ec2b0f96567d49a941d'; |
There was a problem hiding this comment.
Bug: The fetch call to retrieve the OpenAPI schema lacks response validation, which can cause an unhandled rejection and crash the build if the request fails.
Severity: HIGH
Suggested Fix
After the fetch call in resolveOpenAPI.ts, add a check for response.ok. If the response is not successful, throw a descriptive error to prevent the response.json() call from executing on an invalid body and to ensure build failures are clear and debuggable.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/build/resolveOpenAPI.ts#L11
Potential issue: The `fetch` call in `resolveOpenAPI` to retrieve the OpenAPI schema
from `raw.githubusercontent.com` does not validate the HTTP response status. If the
request returns a non-2xx status code (e.g., 404 Not Found), the code will still attempt
to parse the response body using `response.json()`. This will likely throw an error if
the body is not valid JSON, such as an HTML error page. Because the callers of the
parent function `apiCategories()` do not have `try/catch` blocks, this unhandled promise
rejection will crash the build process or the server component at runtime.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.