feat(upload): Disallow creation with upload#5734
Merged
Conversation
jjbayer
changed the title
jjbayer
commented
Mar 18, 2026
Comment on lines
+190
to
+198
| 10, | ||
| 400, | ||
| "stream shorter than lower bound: received 9 < 10", | ||
| "stream shorter than lower bound: received 10 < 11", | ||
| id="smaller_than_announced", | ||
| ), | ||
| pytest.param( | ||
| 11, | ||
| 12, | ||
| 400, | ||
| "stream exceeded upper bound: received 11 > 10", | ||
| "stream exceeded upper bound: received 12 > 11", |
Member
Author
There was a problem hiding this comment.
I'm using a predefined upload location below, which happens to have a length of 11.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
tobias-wilfert
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer allow TUS "creation with upload", so we have full control over the ingestion path of the actual file upload.
Fixes: INGEST-803