ref(processor): Decouple ArtifactProcessor from Kafka message schema#581
Merged
NicoHinderling merged 1 commit intomainfrom Mar 13, 2026
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
Contributor
Sentry Build Distribution
|
NicoHinderling
commented
Mar 13, 2026
| else: | ||
| # If all else fails return unknown | ||
| return ProcessingErrorMessage.UNKNOWN_ERROR | ||
| return ProcessingErrorMessage.UNKNOWN_ERROR |
Contributor
Author
There was a problem hiding this comment.
minor cleanup
fcce11c to
fd1fdde
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
trevor-e
reviewed
Mar 13, 2026
8f447fb to
77d269c
Compare
trevor-e
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Decouples
ArtifactProcessor.process_message()from the Kafka message schema (PreprodArtifactEventsdict) by changing its signature to accept individual parameters (artifact_id,project_id,organization_id,requested_features).This is prep work for the upcoming TaskWorker mode, which calls
process_message()directly without a Kafka message envelope. By making the interface explicit,ArtifactProcessorbecomes reusable by both the Kafka consumer and the TaskWorker.Changes
artifact_processor.py: Replace dict parameter with explicit kwargs. Removesentry_kafka_schemasimport. Addfeaturesparam toprocess_artifact(). Minor cleanups (Dict→dict,raise e→raise, simplify_guess_message).kafka.py: Update_process_in_subprocessto call new signature with keyword args.requirements-dev.txt: Bumpsentry-protosfrom==0.2.0to>=0.4.11.process_messagecall sites in unit and integration tests.Test plan
make checkpasses (lint, format, types)make test-unitpassesmake test-integrationpasses