Skip to content

fix: disable unnecessary fetch_materials option for pipeline-complete branches #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mchen-sentry merged 2 commits into from
Mar 5, 2026
Merged

fix: disable unnecessary fetch_materials option for pipeline-complete branches #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e7aa0
disable fetch materials for pipeline complete and regenerate tests
mchen-sentry Mar 5, 2026
4d17341
Remove orphaned golden files with no matching fixture
mchen-sentry Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libs/gocd-stages.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@ This library is a set of helpers for building GoCD pipelines.
else
null;

local fetch_materials = if std.objectHas(opts, 'fetch_materials') then opts.fetch_materials else null;

{
[name]: {
[if approval != null then 'approval' else null]: approval,
[if fetch_materials != null then 'fetch_materials' else null]: fetch_materials,
jobs: {
[name]: {
tasks: tasks,
Expand Down
4 changes: 2 additions & 2 deletions libs/pipedream.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ local pipedream_trigger_pipeline(pipedream_config) =
materials: materials,
lock_behavior: 'unlockWhenFinished',
stages: [
gocd_stages.basic('pipeline-complete', [gocd_tasks.noop], { approval: 'manual' }),
gocd_stages.basic('pipeline-complete', [gocd_tasks.noop], { approval: 'manual', fetch_materials: false }),
],
},
};
Expand Down Expand Up @@ -210,7 +210,7 @@ local generate_region_pipeline(pipedream_config, pipeline_fn, region, display_or
// The s4s final stage completes and causes the US pipeline to
// re-run. With `pipeline-complete` as the final stage, it isn't
// re-run by a rollback, preventing this domino effect.
gocd_stages.basic('pipeline-complete', [gocd_tasks.noop]),
gocd_stages.basic('pipeline-complete', [gocd_tasks.noop], { fetch_materials: false }),
],
};

Expand Down
8 changes: 8 additions & 0 deletions test/testdata/goldens/pipedream/autodeploy-parallel.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -58,6 +59,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -96,6 +98,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -134,6 +137,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -172,6 +176,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -210,6 +215,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -248,6 +254,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -286,6 +293,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down
8 changes: 8 additions & 0 deletions test/testdata/goldens/pipedream/autodeploy-parallel.jsonnet_single-file.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -52,6 +53,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -85,6 +87,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -118,6 +121,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -151,6 +155,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -184,6 +189,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -217,6 +223,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -250,6 +257,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down
8 changes: 8 additions & 0 deletions test/testdata/goldens/pipedream/autodeploy-serial.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -66,6 +67,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -108,6 +110,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -150,6 +153,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -192,6 +196,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -230,6 +235,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -268,6 +274,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -310,6 +317,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down
8 changes: 8 additions & 0 deletions test/testdata/goldens/pipedream/autodeploy-serial.jsonnet_single-file.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -60,6 +61,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -97,6 +99,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -134,6 +137,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -171,6 +175,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -204,6 +209,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -237,6 +243,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -274,6 +281,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down
6 changes: 6 additions & 0 deletions ...estdata/goldens/pipedream/exclude-regions-autodeploy-parallel.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -58,6 +59,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -96,6 +98,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -134,6 +137,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -172,6 +176,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -210,6 +215,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down
6 changes: 6 additions & 0 deletions ...testdata/goldens/pipedream/exclude-regions-autodeploy-parallel.jsonnet_single-file.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -52,6 +53,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -85,6 +87,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -118,6 +121,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -151,6 +155,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down Expand Up @@ -184,6 +189,7 @@
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
Expand Down
Loading
Loading