Mismatch in Integrity Value for JavaScript File#72
Open
JayanthyChengan wants to merge 5 commits intogdcc:developfrom
Open
Mismatch in Integrity Value for JavaScript File#72JayanthyChengan wants to merge 5 commits intogdcc:developfrom
JayanthyChengan wants to merge 5 commits intogdcc:developfrom
Conversation
qqmyers
requested changes
Jun 25, 2024
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
A few small things:
- the policy so far has been to only make changes in the betatest folder, so I'd ask you to edit previewers/betatest/MapShpPreview.html instead. It would make sense to send a community email to let admins know that they need to update.
- the leaflet script appears to be from the same person and also released w/o a version number - does it make sense to remove the integrity there to to avoid a similar issue?
- Can you add a comment in the file saying ~ integrity values have been removed from the next two scripts because the author updates them without including version info in the name. You may want to make a local install to avoid unexpected changes. See https://github.com/gdcc/dataverse-previewers#fully-local-installation
…le javascripts because the author updates them without including version information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to
#69