Add key step to catalog update instructions#800
Open
edwardchalstrey1 wants to merge 1 commit intomasterfrom
Open
Add key step to catalog update instructions#800edwardchalstrey1 wants to merge 1 commit intomasterfrom
edwardchalstrey1 wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes in this PR
This PR adds a key missing step for developers updating the catalog, which is to make sure the local pygambit install has the new catalog game file(s) included before the update script is run. This is important because the update script calls
pygambit.catalog.games()which won't have the new game(s) otherwise.How to review this PR