Extend player-based colour schemes (Fixes #14) and fix PNG generation issue (Fixes #37) #50
Open
Manik-Khajuria-5 wants to merge 2 commits intogambitproject:mainfrom
Conversation
Member
|
Hi @Manik-Khajuria-5 thanks for this. We will review this once we have received your project proposal. Thanks! |
Author
|
@edwardchalstrey1 I am currently working on project proposal will try to send it as soon as possible |
Member
Thanks, but I believe there is a plenty of time (check the GSoC timeline), so no rush :) |
Author
|
@edwardchalstrey1 okk got it. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the colour scheme functionality in
draw_treeand also fixes a PNG generation bug identified during testing.It now:
This contribution is submitted as part of my GSoC 2026 application (Project Idea 3: Layout algorithm for visualising game trees).
Changes
Colour Scheme Improvements (Fixes #14)
Improved existing
"gambit"colour scheme:Added new
"distinctipy"colour scheme:distinctipypackage to dynamically generate visually distinct colours.Updated
get_player_color():color_schemeparameter.PNG Generation Fix (Related to #37)
Fixed CLI PNG export logic.
Previously, PNG conversion attempted to use a temporary PDF path that was never written.
Updated logic to:
generate_pdf().Verified successful PNG generation locally.
Dependencies
distinctipyTesting
Tested locally using sample
.effiles.Verified correct TikZ output for:
"gambit"scheme"distinctipy"schemeVerified:
Fixes #14
Default
Gambit
Distinctipy
Fixes [#37]
Closes #14
Closes #37