Open
Conversation
//const initialNotes = await api //initialNotes määritelty beforeAll, menee ehkä sekaisin testien kanssa Voisi siis ehkä olla nk. responseBeforePost ja responseAfterPost, jos nimeämiskäytäntö on vaan oikein? Testi bugaa mielestäni tässä: // expect(response.body.length).toBe(initialNotes.length) Comparing two different types of values. Expected undefined but received number. Eli pitäisi olla siis initialNotes.body. mutta ehkä selkeämpi siis ehkä: expect(responseAfterPost.body.length).toBe(responseBeforePost.body.length); Yleisesti ottain noiden .length kanssa on saanut muutenkin tapella, kun on yrittänyt etsiä sellaista kätevää sql ISNULL tyyppistä löytääkseen milloin joku on siis null :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//const initialNotes = await api //initialNotes määritelty beforeAll, menee ehkä sekaisin testien kanssa
Voisi siis ehkä olla nk. responseBeforePost ja responseAfterPost, jos nimeämiskäytäntö on vaan oikein?
Testi bugaa mielestäni tässä: // expect(response.body.length).toBe(initialNotes.length)
Comparing two different types of values. Expected undefined but received number.
Eli pitäisi olla siis initialNotes.body. mutta ehkä selkeämpi siis ehkä: expect(responseAfterPost.body.length).toBe(responseBeforePost.body.length);
Yleisesti ottain noiden .length kanssa on saanut muutenkin tapella, kun on yrittänyt etsiä sellaista kätevää sql ISNULL tyyppistä löytääkseen milloin joku on siis null :)