Skip to content

Feat/verdaccio venv - support pr libs to work on venv#111

Open
AlexFrontegg wants to merge 33 commits intomasterfrom
feat/verdaccio-venv
Open

Feat/verdaccio venv - support pr libs to work on venv#111
AlexFrontegg wants to merge 33 commits intomasterfrom
feat/verdaccio-venv

Conversation

@AlexFrontegg
Copy link
Copy Markdown
Contributor

@AlexFrontegg AlexFrontegg commented Apr 10, 2026

Note

Medium Risk
Adds a new conditional path in the start-venv CI workflow that runs a local Verdaccio registry, publishes prerelease @frontegg/* packages, and alters image tagging/pushing behavior; failures or misconfiguration could break venv builds or produce unexpected images/appVersions.

Overview
Adds an opt-in Verdaccio mode to start-venv.yaml (useVerdaccio, templateAndLibsBranch) to build venv Docker images using locally published @frontegg/* packages from a specified template-and-libs branch.

When enabled, the workflow starts Verdaccio, detects and publishes only changed packages via lerna, rewrites registry config/lockfiles to consume the published prerelease versions, and pushes images with unique shadow-<run_id>-<attempt>-<sha> tags (or creates the tag alias when no libs changed). It also updates the venv repo appVersion values to match the shadow-* tags and adds input validation plus buildx host-networking to support the local registry.

Reviewed by Cursor Bugbot for commit b2c67d4. Bugbot is set up for automated code reviews on this repo. Configure here.

- Explicit Verdaccio config with npmjs proxy and uplink token

- Selective lerna publish without force-publish

- scripts/test-verdaccio-flow.sh and README for local validation

Made-with: Cursor
…blish strategy

- fetch-depth: 0 for template-and-libs so lerna has version tags
- Explicit Verdaccio health check failure after retry loop
- Single `lerna changed` call, result passed via GITHUB_OUTPUT
- Dropped `--no-git-tag-version`, switched to `from-package` so publish
  works without git tags
- Build + register + publish steps skipped when no packages changed

Made-with: Cursor
…de-dependents only for yarn up

Made-with: Cursor
@AlexFrontegg AlexFrontegg changed the title Feat/verdaccio venv Feat/verdaccio venv - support pr libs to work on venv Apr 10, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Missing base64 -w 0 may break git auth header
    • Added -w 0 flag to base64 command to prevent line wrapping that would corrupt the authorization header for long tokens.

Create PR

Or push these changes by commenting:

@cursor push ffd44feb53
Preview (ffd44feb53)
diff --git a/.github/workflows/start-venv.yaml b/.github/workflows/start-venv.yaml
--- a/.github/workflows/start-venv.yaml
+++ b/.github/workflows/start-venv.yaml
@@ -276,7 +276,7 @@
           TARGET_BRANCH: ${{ inputs.templateAndLibsBranch }}
           GH_TOKEN: ${{ secrets.GH_REPOSITORY_ADMIN_TOKEN }}
         run: |
-          AUTH="$(printf 'x-access-token:%s' "${GH_TOKEN}" | base64)"
+          AUTH="$(printf 'x-access-token:%s' "${GH_TOKEN}" | base64 -w 0)"
           git config --local http.https://github.com/.extraheader "AUTHORIZATION: basic ${AUTH}"
 
           REFSPEC_MASTER="+refs/heads/master:refs/remotes/origin/master"

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6013780. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant