Feat/verdaccio venv - support pr libs to work on venv#111
Open
AlexFrontegg wants to merge 33 commits intomasterfrom
Open
Feat/verdaccio venv - support pr libs to work on venv#111AlexFrontegg wants to merge 33 commits intomasterfrom
AlexFrontegg wants to merge 33 commits intomasterfrom
Conversation
- Explicit Verdaccio config with npmjs proxy and uplink token - Selective lerna publish without force-publish - scripts/test-verdaccio-flow.sh and README for local validation Made-with: Cursor
Made-with: Cursor
…blish strategy - fetch-depth: 0 for template-and-libs so lerna has version tags - Explicit Verdaccio health check failure after retry loop - Single `lerna changed` call, result passed via GITHUB_OUTPUT - Dropped `--no-git-tag-version`, switched to `from-package` so publish works without git tags - Build + register + publish steps skipped when no packages changed Made-with: Cursor
…istory Made-with: Cursor
Made-with: Cursor
…e in v6) Made-with: Cursor
…g template-and-libs CI Made-with: Cursor
…w packages Made-with: Cursor
…ock support Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
…host Made-with: Cursor
…Verdaccio Made-with: Cursor
…lutions Made-with: Cursor
…n, shadow tags Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
…go redeploy Made-with: Cursor
…r redeploy Made-with: Cursor
Made-with: Cursor
…tive dependents Made-with: Cursor
…upported lerna --scope Made-with: Cursor
…de-dependents only for yarn up Made-with: Cursor
…and-libs Made-with: Cursor
Made-with: Cursor
…summary Made-with: Cursor
Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Missing
base64 -w 0may break git auth header- Added
-w 0flag to base64 command to prevent line wrapping that would corrupt the authorization header for long tokens.
- Added
Or push these changes by commenting:
@cursor push ffd44feb53
Preview (ffd44feb53)
diff --git a/.github/workflows/start-venv.yaml b/.github/workflows/start-venv.yaml
--- a/.github/workflows/start-venv.yaml
+++ b/.github/workflows/start-venv.yaml
@@ -276,7 +276,7 @@
TARGET_BRANCH: ${{ inputs.templateAndLibsBranch }}
GH_TOKEN: ${{ secrets.GH_REPOSITORY_ADMIN_TOKEN }}
run: |
- AUTH="$(printf 'x-access-token:%s' "${GH_TOKEN}" | base64)"
+ AUTH="$(printf 'x-access-token:%s' "${GH_TOKEN}" | base64 -w 0)"
git config --local http.https://github.com/.extraheader "AUTHORIZATION: basic ${AUTH}"
REFSPEC_MASTER="+refs/heads/master:refs/remotes/origin/master"This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6013780. Configure here.
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Adds a new conditional path in the
start-venvCI workflow that runs a local Verdaccio registry, publishes prerelease@frontegg/*packages, and alters image tagging/pushing behavior; failures or misconfiguration could break venv builds or produce unexpected images/appVersions.Overview
Adds an opt-in Verdaccio mode to
start-venv.yaml(useVerdaccio,templateAndLibsBranch) to build venv Docker images using locally published@frontegg/*packages from a specifiedtemplate-and-libsbranch.When enabled, the workflow starts Verdaccio, detects and publishes only changed packages via
lerna, rewrites registry config/lockfiles to consume the published prerelease versions, and pushes images with uniqueshadow-<run_id>-<attempt>-<sha>tags (or creates the tag alias when no libs changed). It also updates the venv repoappVersionvalues to match theshadow-*tags and adds input validation plusbuildxhost-networking to support the local registry.Reviewed by Cursor Bugbot for commit b2c67d4. Bugbot is set up for automated code reviews on this repo. Configure here.