Resolve react and framer-motion versions from framer package#592
Merged
huntercaron merged 7 commits intomainfrom Mar 12, 2026
Merged
Resolve react and framer-motion versions from framer package#592huntercaron merged 7 commits intomainfrom
huntercaron merged 7 commits intomainfrom
Conversation
github-actions
bot
added
the
Auto submit to Marketplace on merge
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
huntercaron
removed
the
Auto submit to Marketplace on merge
niekert
reviewed
Mar 12, 2026
| const coreImports = CORE_LIBRARIES.map(lib => `import "${lib}";`).join("\n") | ||
| const coreImports = [ | ||
| ...(await this.buildPinnedImports(CORE_LIBRARIES)), | ||
| ...(await this.buildPinnedImports(["@types/react"])), |
Member
There was a problem hiding this comment.
I'm missing context on this but why is @types/react not in CORE_LIBRARIES?
Collaborator
Author
There was a problem hiding this comment.
Good point, actually gonna put react, react-dom in there and remove the type import so its a bit clearer
niekert
reviewed
Mar 12, 2026
huntercaron
changed the title
…definitions Sending both `import "react"` and `import "@types/react"` through ATA caused two separate ReactElement type resolutions, breaking addPropertyControls and other APIs expecting ComponentType.
huntercaron
force-pushed
the
huntercaron/pin-react18-ata
branch
from
5f67f28 to
ea0e0a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves ATA pins (the runtime types installer) from the published
framerpackage metadata instead of hardcoding React and Framer Motion versions. Addsreact-domto core ATA acquisition and prefers the pinned version when synthesizing@types/*/package.jsonfiles.Changelog
framer,framer-motion,react, andreact-domATA pins fromframer@latest.process()deduplication.QA
reactandreact-domare18.2.0framer-motionis12.34.3