Fix Turkish glossary: sorting, language links, related terms, empty entries#666
Merged
LukasWallrich merged 3 commits intomasterfrom Feb 26, 2026
Merged
Fix Turkish glossary: sorting, language links, related terms, empty entries#666LukasWallrich merged 3 commits intomasterfrom
LukasWallrich merged 3 commits intomasterfrom
Conversation
…pty entries - Add sort_key to generation script so Turkish special chars (ö, ç, ğ, ı, ş, ü) sort correctly relative to their base letters instead of after 'z'; regenerate all glossary files with sort_key - Fix language switcher to show "Also available in" for terms whose title is identical across languages (BIZARRE, FORRT, Git, HARKing, etc.) by falling back to the title itself when no [English] brackets are present - Fix related terms in non-English glossaries to link to English entries when no translation-language page exists - Skip entries with empty definitions in all languages; delete 11 existing empty-definition files (8 Turkish, 2 English, 1 Arabic) - Update Turkish landing page text from source GDoc (örn. abbreviation, sentence punctuation, mentörlük spelling, en-dash in citation, son-baskı versiyonu link text) Closes #663 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
📝 Spell Check ResultsFound 1 potential spelling issue(s) in this PR: 📄
|
| Line | Issue |
|---|---|
| 17 | Wit ==> With |
ℹ️ How to address these issues:
- Fix the typo: If it's a genuine typo, please correct it.
- Add to whitelist: If it's a valid word (e.g., a name, technical term), add it to
.codespell-ignore.txt - False positive: If this is a false positive, please report it in the PR comments.
🤖 This check was performed by codespell
Contributor
Author
|
✅ Staging Deployment Status This PR has been successfully deployed to staging as part of an aggregated deployment. Deployed at: 2026-02-26 09:33:17 UTC The staging site shows the combined state of all compatible open PRs. |
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
richarddushime
approved these changes
Feb 26, 2026
Contributor
richarddushime
left a comment
richarddushime
left a comment
There was a problem hiding this comment.
LGTM 👍
Fingers Crossed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #663
What this fixes
✅ O/Ö sorting scrambled
Added a
sort_keyfield to the generation script. For Turkish, special characters are mapped to ASCII equivalents that sort correctly (e.g.ö → oz,ç → cz) so Ö-terms appear between O and P in the TOC, not after Z. The template now sorts bysort_keyin both desktop and mobile TOCs.✅ "Also available in" links missing for same-named terms
BIZARRE, FORRT, Git, HARKing, etc. have the same title in Turkish and English (no
[English]brackets). The language switcher now falls back to using the title directly when no brackets are found, so these terms correctly show their cross-language links.✅ Related terms not linked
Turkish
related_termsvalues use English term names (e.g. "Open access", "Paywall"). The template now falls back to the English glossary when no match is found in the current language, making these terms clickable.✅ Entries without Turkish definitions appearing (WEIRD, Sherpa/RoMEO, OERs, etc.)
The generation script now skips entries with empty definitions for all languages. 11 existing empty-definition files were deleted (8 Turkish, 2 English, 1 Arabic).
✅ Turkish landing page updated
Text updated from the source GDoc: abbreviation style (
örn.,), sentence punctuation,mentörlükspelling, en-dash in citation, andson-baskı versiyonulink text.✅ Glossary regenerated
Script re-run to pick up all changes; 4 new Turkish entries added from the sheet, all files now include
sort_key.Not addressed in this PR
See issue comments for remaining items.
🤖 Generated with Claude Code