Skip to content

Add Re-SearchTerms Shiny app as full-screen iframe at /re_searchterms#665

Merged
richarddushime merged 11 commits intomasterfrom
copilot/embed-researchterms-app
Feb 26, 2026
Merged

Add Re-SearchTerms Shiny app as full-screen iframe at /re_searchterms#665
richarddushime merged 11 commits intomasterfrom
copilot/embed-researchterms-app

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

Embeds the Re-SearchTerms v2 Shiny app at forrt.org/re-searchterms as a full-screen iframe, following the same pattern as the FLoRA Annotator and FReD Explorer pages.

Changes

  • New static page: static/apps/re_searchterms.html — a standalone full-screen HTML page (no site chrome) with an iframe pointing to https://msleungyi.shinyapps.io/Re-SearchTerms_v2/, identical in structure to static/apps/flora_annotator.html and static/apps/fred_explorer.html.
  • Redirect: Added /re-searchterms/apps/re_searchterms.html (301) in netlify.toml, keeping the URL clean and consistent with /annotator and /explorer.
Original prompt

This section details on the original issue you should resolve

<issue_title>embed researchterms</issue_title>
<issue_description>Embed this app in iframe (like other shiny apps) at forrt.org/re-searchterms

https://msleungyi.shinyapps.io/Re-SearchTerms_v2/</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>
Copilot AI changed the title [WIP] Embed research terms app in iframe Add Re-SearchTerms Shiny app embed at /re-searchterms Feb 24, 2026
Copilot AI requested a review from LukasWallrich February 24, 2026 16:11
@LukasWallrich LukasWallrich marked this pull request as ready for review February 25, 2026 16:36
@LukasWallrich LukasWallrich requested a review from a team as a code owner February 25, 2026 16:36
@LukasWallrich
Copy link
Contributor

Looks good to me - but need to check deploy

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

📝 Spell Check Results

Found 1 potential spelling issue(s) in this PR:

📄 content/glossary/english/open_material.md

Line Issue
16 Wit ==> With

ℹ️ How to address these issues:

  1. Fix the typo: If it's a genuine typo, please correct it.
  2. Add to whitelist: If it's a valid word (e.g., a name, technical term), add it to .codespell-ignore.txt
  3. False positive: If this is a false positive, please report it in the PR comments.

🤖 This check was performed by codespell

@github-actions
Copy link
Contributor

👍 All image files/references (if any) are in webp format, in line with our policy.

@LukasWallrich
Copy link
Contributor

LukasWallrich commented Feb 25, 2026

Staging Deployment Status

This PR has been successfully deployed to staging as part of an aggregated deployment.

Deployed at: 2026-02-26 09:33:17 UTC
Staging URL: https://staging.forrt.org

The staging site shows the combined state of all compatible open PRs.

@LukasWallrich
Copy link
Contributor

@copilot make this a full-screen iframe, not embedded in the page

Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 25, 2026

@copilot make this a full-screen iframe, not embedded in the page

Done in commit 6fed603. Replaced the embedded-in-page approach with a full-screen standalone HTML page (static/apps/re_searchterms.html) — same pattern as the FLoRA Annotator and FReD Explorer. Added a /re-searchterms/apps/re_searchterms.html redirect in netlify.toml so the URL stays clean.

Copilot AI changed the title Add Re-SearchTerms Shiny app embed at /re-searchterms Add Re-SearchTerms Shiny app as full-screen iframe at /re-searchterms Feb 25, 2026
@richarddushime
Copy link
Contributor

the redirect is not working yet as expected
returing 404

@richarddushime richarddushime changed the title Add Re-SearchTerms Shiny app as full-screen iframe at /re-searchterms Add Re-SearchTerms Shiny app as full-screen iframe at /re_searchterms Feb 26, 2026
@richarddushime
Copy link
Contributor

richarddushime commented Feb 26, 2026

Now using /re_searchterms not re-searchterms

@LukasWallrich
Copy link
Contributor

Should not redirect but be embedded. Also, they call it re-searchterms - can we use their name?

Copy link
Contributor

@richarddushime richarddushime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@richarddushime richarddushime merged commit 852ddfb into master Feb 26, 2026
5 checks passed
@richarddushime richarddushime deleted the copilot/embed-researchterms-app branch February 26, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

embed researchterms

3 participants