fix(session): make teardown idempotent with handle-based cleanup#245
Merged
forketyfork merged 2 commits intomainfrom Feb 25, 2026
Merged
fix(session): make teardown idempotent with handle-based cleanup#245forketyfork merged 2 commits intomainfrom
forketyfork merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the SessionState cleanup logic in deinit and resetForRespawn to make teardown idempotent by cleaning up resources based on handle presence rather than the spawned lifecycle flag. The SIGTERM signal is still guarded by spawned and !dead, but resource deinitialization now happens unconditionally when handles exist.
Changes:
- Modified
deinitto clean up shell, stream, and terminal based on handle presence rather thanspawnedflag - Modified
resetForRespawnto use the same handle-based cleanup pattern - Lifecycle flags (
spawned,dead,cwd_settled) are now reset unconditionally outside handle checks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionState.deinitclean upshell,stream, andterminalbased on handle presence instead of thespawnedflagSIGTERMguarded byspawned and !dead, but always deinit and null out owned handlesresetForRespawnWhy
This makes teardown idempotent when lifecycle flags and handles drift out of sync, avoiding stale-resource deinit crashes during close/relaunch paths.
Validation