Make Alpine app use better Alpine conventions#9
Open
markjaquith wants to merge 1 commit intofireship-io:mainfrom
Open
Make Alpine app use better Alpine conventions#9markjaquith wants to merge 1 commit intofireship-io:mainfrom
markjaquith wants to merge 1 commit intofireship-io:mainfrom
Conversation
- fixed broken use of x-for on `<ul>` - removed unnecessary use of global state - removed unnecessary function - move storage syncing to an `x-effect` - `@submit` instead of `x-on:submit` - Reset input field after submission - Formatting cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Great video, by the way)
The Alpine app doesn't actually work right now (you can't use
x-foron a<ul>— only on a<template>), and it was coded in not a very Alpine-y way. This PR is a much more idiomatic implementation.<ul>x-effect@submitinstead ofx-on:submit