DRV-20: Fix math.frexp/ldexp Lua 5.3+ compatibility#10
Merged
svc-finitelabs[bot] merged 2 commits intomainfrom Mar 24, 2026
Merged
DRV-20: Fix math.frexp/ldexp Lua 5.3+ compatibility#10svc-finitelabs[bot] merged 2 commits intomainfrom
svc-finitelabs[bot] merged 2 commits intomainfrom
Conversation
…atibility math.frexp and math.ldexp were removed in Lua 5.3 (without LUA_COMPAT_MATHLIB). Add conditional polyfills that use the native functions when available and fall back to pure Lua implementations on 5.3+. Fixes DRV-20
derek-miller
previously approved these changes
Mar 24, 2026
Contributor
|
@svc-finitelabs this is good to merge |
derek-miller
approved these changes
Mar 24, 2026
Contributor
Author
|
Merged via squash. Branch deleted. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add conditional polyfills for
math.frexpandmath.ldexpwhich were removed in Lua 5.3+ (withoutLUA_COMPAT_MATHLIB).Uses native functions when available, falls back to pure Lua implementations on 5.3+.
4 occurrences in
src/protobuf/init.lua(IEEE 754 float/double encode/decode).Part of DRV-15 (Lua 5.3+ compat audit). Fixes DRV-20