Add PHPStan for static analysis and add support for PHP 7.4+#7
Merged
fahad19 merged 4 commits intofeaturevisor:mainfrom Aug 18, 2025
Merged
Add PHPStan for static analysis and add support for PHP 7.4+#7fahad19 merged 4 commits intofeaturevisor:mainfrom
fahad19 merged 4 commits intofeaturevisor:mainfrom
Conversation
Level 3 is highest possible to achieve with minimal effort for now.
fahad19
reviewed
Aug 18, 2025
fahad19
approved these changes
Aug 18, 2025
Member
|
thanks @Greg0! will merge and release if I have your approval. |
Greg0
commented
Aug 18, 2025
Contributor
Author
Greg0
left a comment
There was a problem hiding this comment.
Yes, it can be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #5
Overview
This PR introduces PHPStan static analysis to the project and resolves compatibility issues to ensure proper support for PHP 7.4+. The changes improve code quality, type safety, and maintain backward compatibility with older PHP versions.
Changes
🔧 Static Analysis Setup
srcandtestsdirectories. Level 3 is very low but only this level can be achieved with minimal effort.📦 Dependency Management
^10→^9^2.0→^1.1PHPStan Configuration
The current PHPStan configuration uses level 3, which is intentionally conservative to establish a baseline for static analysis. This low level was chosen because:
array $optionswithout specific type definitions