Merged
Conversation
Pass `date` a format for the date output. To check we can run a process we fork out and run `date` and check the output matches a regex. The regex expects something like this: 'Mon Mar 23 09:30:57 UTC 2026'. But the format date prints by default depends on the LANG environment variable. And when you work with a bunch of Australian's some are going to have LANG=en_AU.UTF-8 which produces a date like this: 'Mon 23 Mar 2026 20:30:07 AEDT'
Davis-A
force-pushed
the
tests-fix-basic.t
branch
from
999812a to
b84136c
Compare
Member
Author
|
Well figured that out, Anyway, TIL: |
Davis-A
changed the title
rjbs
approved these changes
Mar 23, 2026
| : die "This test requires either /bin/date or /usr/bin/date exist."; | ||
|
|
||
| my $f = $hub->run_process([ $date ]); | ||
| my $f = $hub->run_process([ $date, '+%a %b %e %I:%M:%S %p %Z %Y']); |
Member
There was a problem hiding this comment.
%s would be even easier to know it wasn't affected by env. ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't matching the output of the date command on my laptop, or on an inabox. Make the regex a bit looseredit: see below