fix: support fastify/websocket handlers (fastify/otel#136)#137
Merged
mcollina merged 3 commits intofastify:mainfrom Mar 8, 2026
Merged
fix: support fastify/websocket handlers (fastify/otel#136)#137mcollina merged 3 commits intofastify:mainfrom
mcollina merged 3 commits intofastify:mainfrom
Conversation
metcoder95
reviewed
Mar 6, 2026
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
Can we add a piece of documentation that states what happen if the handler is not well-formed?
The rest lgtm.
metcoder95
approved these changes
Mar 8, 2026
Tony133
approved these changes
Mar 8, 2026
gurgunday
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and new tests to resolve #136
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct