Fix PyAV compatibility issue with DISPLAYMATRIX access#718
Open
paruparu wants to merge 1 commit intofacebookresearch:mainfrom
Open
Fix PyAV compatibility issue with DISPLAYMATRIX access#718paruparu wants to merge 1 commit intofacebookresearch:mainfrom
paruparu wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
… stream metadata retrieval. This change ensures compatibility with older PyAV versions or different video stream types by providing a fallback value of 0 for rotation degrees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes video upload error caused by missing
side_dataattribute in newer PyAV versions (resolves #497).Problem
Users cannot upload videos due to
AttributeError: 'VideoCodecContext' object has no attribute 'side_data'. Current workaround requires downgrading PyAV to 13.1.0.Solution
Added error handling for
side_dataaccess in video metadata retrieval, providing fallback value when attribute is not available.Changes
get_video_metadata()functionside_datais unavailableFixes #497