This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Making seq2seq_model more torchscript-friendly#1459
Open
shreydesai wants to merge 2 commits intofacebookresearch:mainfrom
Open
Making seq2seq_model more torchscript-friendly#1459shreydesai wants to merge 2 commits intofacebookresearch:mainfrom
shreydesai wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23673319 |
Differential Revision: D23602908 fbshipit-source-id: 22c7a7eea40231de80bc651bc585749042bb33e0
Summary: Pull Request resolved: facebookresearch#1459 seq2seq_model.py changes: - removes dependence on _ when unpacking the tensor dicts - explicit None checks on dict feats Differential Revision: D23673319 fbshipit-source-id: dd0f8e164b7368a6eef7fcf02a1a15a3c078f33e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23673319 |
shreydesai
force-pushed
the
export-D23673319
branch
from
4d401d3 to
4be819b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
seq2seq_model.py changes:
Differential Revision: D23673319