This repository was archived by the owner on Jan 10, 2020. It is now read-only.
Update AfterEffects and iOS Keyframes to Support XY Rotation#110
Open
jacksontaylor13 wants to merge 5 commits intofacebookarchive:masterfrom
Open
Update AfterEffects and iOS Keyframes to Support XY Rotation#110jacksontaylor13 wants to merge 5 commits intofacebookarchive:masterfrom
jacksontaylor13 wants to merge 5 commits intofacebookarchive:masterfrom
Conversation
After Effects Script: Added in functionality to support the XY rotation on a 3D layer in After Effects. If you perform the transformation on the of the you will be able to animate the 3-D axes also. Currently the support is only for Z-axis rotation, so this PR will add in the new functionality. In the Keyframes file, once exported, the keys used for X and Y rotation are and , respectively. iOS SDK: In order to interpret and handle the new 3D layer transformations, the iOS SDK will now be able to intepret the values and insert the animations accordingly. Using a new enumeration on the class, you are able to specify which axis the rotation animation should occur on. This will hopefully help abstract some of the code in that file, to prevent duplication.
Author
|
Since this PR deals with rotation, also included a fix for issue #106. |
Contributor
|
@jacksontaylor13 updated the pull request - view changes |
renyu-io
approved these changes
Feb 11, 2017
Contributor
renyu-io
left a comment
renyu-io
left a comment
There was a problem hiding this comment.
Thank you for your changes 👍
Contributor
|
@LazyChild has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@jacksontaylor13 updated the pull request - view changes - changes since last import |
Contributor
|
@LazyChild has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
kjhgg
approved these changes
Apr 30, 2018
|
Hf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Effects Script: Added in functionality to support the XY rotation on a 3D layer in After Effects. If you perform the transformation on the
Transformof theShape Layeryou will be able to animate the 3-D axes also. Currently the support is only for Z-axis rotation, so this PR will add in the new functionality. In the Keyframes file, once exported, the keys used for X and Y rotation areX_ROTATIONandY_ROTATION, respectively.iOS SDK: In order to interpret and handle the new 3D layer transformations, the iOS SDK will now be able to intepret the values and insert the animations accordingly. Using a new
KFAxisenumeration on theKFVectorAnimationLayerclass, you are able to specify which axis the rotation animation should occur on. This will hopefully help abstract some of the code in that file, to prevent duplication.