exercises(robot-simulator): implement#558
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
ilmanzo
force-pushed
the
robot_simulator
branch
2 times, most recently
from
132889d to
66871ee
Compare
ilmanzo
force-pushed
the
robot_simulator
branch
from
66871ee to
651c634
Compare
Improve error messages on test failure.
Make the order match their usage in `move`.
Be consistent with the other test files on the track.
The other suite names are like this.
ynfle
left a comment
ynfle
left a comment
There was a problem hiding this comment.
Overall looks great.
My only comment would be that perhaps the instructions could be a seq of an enum to ensure type safety at the caller level. Non blocking, though
|
I'm going to merge this in a couple of days if @ee7 is available for a review |
3 participants
Reference to issue #555
Implement the missing robot-simulator exercise in Nim