feat(docs): adopt /ship command and shipping workflow#49
Merged
Conversation
Add the /ship command adapted from everruns/everruns for the SDK repo. Includes shipping spec, AGENTS.md updates, and `just fmt` recipe. - .claude/commands/ship.md: 8-phase ship workflow (pre-flight, test coverage, artifact updates, smoke testing, quality gates, push/PR, CI/merge, post-merge) - specs/shipping.md: shipping spec defining phases, quality core, test coverage requirements, artifact sync rules - AGENTS.md: Commands and Shipping sections, spec reference - justfile: `fmt` recipe for auto-fix formatting across all SDKs https://claude.ai/code/session_01DzkBhQ5yRVrh2ryCZraeNS
Lock files were stale — version still referenced 0.1.2 while Cargo.toml and pyproject.toml were already bumped to 0.1.3. https://claude.ai/code/session_01DzkBhQ5yRVrh2ryCZraeNS
Make it unambiguous across ship command, shipping spec, and AGENTS.md that "ship" = PR merged to main. Not done until merged. https://claude.ai/code/session_01DzkBhQ5yRVrh2ryCZraeNS
Add Phase 5 (Code Simplification) and Phase 6 (Security Review) to the ship command. These expand the quality core from phases 2-4 to 2-6. - Simplification: duplication, over-engineering, clarity, consistency - Security: OWASP Top 10, SDK-specific risks (key redaction, TLS, input validation) - Updated specs/shipping.md with new phase table and requirements https://claude.ai/code/session_01DzkBhQ5yRVrh2ryCZraeNS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/shipcommand from everruns/everruns, adapted for the multi-language SDK repo (Rust, Python, TypeScript)specs/shipping.mddefining the 8-phase shipping workflow, quality core, and test coverage requirementsjust fmtrecipe for auto-fix formatting across all SDKs (referenced by ship command's quality gates phase)Test Plan
just test— 155 tests across all 3 SDKs)just lint)Checklist
specs/shipping.mdhttps://claude.ai/code/session_01DzkBhQ5yRVrh2ryCZraeNS