Added auto reconnect while listening.#2
Open
carsondarling wants to merge 2 commits intoerrorception:masterfrom
Open
Added auto reconnect while listening.#2carsondarling wants to merge 2 commits intoerrorception:masterfrom
carsondarling wants to merge 2 commits intoerrorception:masterfrom
Conversation
The function signature is now: `cumin.listen(queueName, handler, autoReconnect)`. If `autoReconnect` is a truthy value, then handlers are attached to both the block and the non-blocking client, so when a Redis connection drops, the process won't exit. In addition, when the blocking client reconnects, it restarts listening for items from the queue. I haven't added any tests for this functionality (I didn't want to expose the redis-clients just for testing), but I would be happy to add them if you have a suggested way of doing it.
Also added argument shuffle to make sure we didn't break backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function signature is now:
cumin.listen(queueName, autoReconnect, handler). IfautoReconnectis a truthy value, then handlers are attached to both the block and the non-blocking client, so when a Redis connection drops, the process won't exit. In addition, when the blocking client reconnects, it restarts listening for items from the queue. This is still backwards compatible with old code, and should have no effect on existing code that depends on cumin.I haven't added any tests for this functionality (I didn't want to expose the Redis clients just for testing), but I would be happy to add them if you have a suggested way of doing it.