Merged
Conversation
kripken
reviewed
Mar 12, 2026
| if opt_level == 0 or '-g' in params: | ||
| assert looks_unminified | ||
| elif opt_level >= 2: | ||
| assert looks_minified |
Member
There was a problem hiding this comment.
One thing I'm not sure if other tests cover is closure (that closure runs exactly when asked). Code size tests might indirectly, but I think those run without closure so that we can see function names?
Collaborator
Author
There was a problem hiding this comment.
The codesize tests absolutes do use closure. We sometimes build twice to get names I think but the core measurements are all about closure.
Collaborator
Author
There was a problem hiding this comment.
Hmm.. I just noticed that closure is always 0 here... i.e. we are not actually ever testing if closure ran
Collaborator
Author
There was a problem hiding this comment.
This seems like even more evidence that this test is bittrotted/not doing much anymore.
This is a rather sprawling and unfocused test that has a huge loop inside. This single test take over 30 seconds to run. It seems to test for a lot of different things, including stuff from the old compile-to-JS days. I'm pretty sure all this stuff is covered in a more logical fashion elsewhere. It also has a very useless name.
kripken
approved these changes
Mar 12, 2026
| if opt_level == 0 or '-g' in params: | ||
| assert looks_unminified | ||
| elif opt_level >= 2: | ||
| assert looks_minified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rather sprawling and unfocused test that has a huge loop inside.
This single test take over 30 seconds to run.
It seems to test for a lot of different things, including stuff from the old compile-to-JS days. I'm pretty sure all this stuff is covered in a more logical fashion elsewhere.
It also has a very useless name.