docs: add some OTel attributes for DynamoDB spec#817
Draft
david-luna wants to merge 3 commits intomainfrom
Draft
docs: add some OTel attributes for DynamoDB spec#817david-luna wants to merge 3 commits intomainfrom
david-luna wants to merge 3 commits intomainfrom
Conversation
estolfo
reviewed
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of OTel attributes in DynamoDB instrumentation. These attributes are:
Having this information will be relevant to when analysing which table, and projection if applies, triggered the error or a slow execution.
May the instrumentation collect sensitive information, such as secrets or PII (ex. in headers)?
Yes
sanitize_field_names)No
Create PR as draft
Approval by at least one other agent
Mark as Ready for Review (automatically requests reviews from all agents and PM via
CODEOWNERS)Approved by at least 2 agents + PM (if relevant)
Merge after 7 days passed without objections
To auto-merge the PR, add
/schedule YYYY-MM-DDto the PR description.Create implementation issues through the meta issue template (this will automate issue creation for individual agents)
If this spec adds a new dynamic config option, [add it to central config](https://github.com/elastic/apm/blob/main/specs/agents/configuration.md#adding-a-new-configuration-option).