Snooker table tuning

[alrusdi]

This is my attempt to fix some annoying things in snooker implementation.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9e651ba7-0d3f-4e76-a61c-04abeeda6803

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[alrusdi]

Snooker table standarts according to WBSPA

[alrusdi]

Fix baulk line balls positions

[ekiefl]

Looks really good!

I noticed two things.

The parameters defined in collection.py really closely match the table model. Beautiful. The only thing I noticed is highlighted in the picture below.

The table geometry height is lower than in the model. I'm not sure which one is correct but ideally they should match. If you want to play around with this, replace lines 136-140 with:

        if True:

Second, the pool table has baked in cushion shadows that adds some easy realism.

---

If you're happy, I'm happy. We can either merge as is or you can make changes to address these two points. Up to you! Just let me know.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.36%. Comparing base (d6b1bef) to head (b3db968).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   46.36%   46.36%           
=======================================
  Files         144      144           
  Lines       10315    10315           
=======================================
  Hits         4783     4783           
  Misses       5532     5532           

Flag	Coverage Δ
service	46.36% <ø> (ø)
service-no-ani	56.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[alrusdi]

Looks really good!

I noticed two things.

...

If you're happy, I'm happy. We can either merge as is or you can make changes to address these two points. Up to you! Just let me know.

I suggest merging this part as is, and I'll address both comments in a separate MR. We can also decide there how best to add the model source file. I'll optimize it a bit, but it'll still be ~70 MB... Won't that bloat the repository too much? Maybe it's better to store it in a separate repo like "pooltool-assets" or something?

[ekiefl]

I suggest merging this part as is, and I'll address both comments in a separate MR. We can also decide there how best to add the model source file. I'll optimize it a bit, but it'll still be ~70 MB... Won't that bloat the repository too much? Maybe it's better to store it in a separate repo like "pooltool-assets" or something?

Ok I'll merge now.

Good thinking about a separate repo. 70MB is tolerable (we've done worse) but it's not sustainable. I'll implement this soon.