Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a custom Source Control (SCM) integration to surface locally modified SuperOffice scripts in VS Code and enable diffs against the originally downloaded server content, while also refactoring “provider” implementations into src/providers and improving tree-loading UX.
Changes:
- Introduces
ScmService+ScmTextDocumentContentProviderand wires script downloads to start tracking originals for diff/discard. - Refactors authentication/tree providers out of
src/contributesintosrc/providersand updates imports/registrations accordingly. - Updates UI contributions (commands/SCM menus/views) and adds progress notifications when fetching scripts/extra tables.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/vscode-extension/src/services/scriptService.ts | Tracks downloaded scripts in SCM immediately after writing to disk. |
| packages/vscode-extension/src/services/scmService.ts | Implements a custom VS Code SCM provider and persistence for original script content. |
| packages/vscode-extension/src/services/fileSystemService.types.ts | Extracts SuoFile type into a dedicated types file. |
| packages/vscode-extension/src/services/fileSystemService.ts | Updates imports and uses extracted SuoFile type. |
| packages/vscode-extension/src/services/authenticationService.ts | Updates UserClaims import path after refactor. |
| packages/vscode-extension/src/providers/scriptTreeDataProvider.ts | Adds progress UI while fetching scripts; updates command import path. |
| packages/vscode-extension/src/providers/scmTextDocumentContentProvider.ts | Adds content provider for superoffice-original:// URIs to support diffs. |
| packages/vscode-extension/src/providers/extraTablesTreeDataProvider.ts | Adds extra tables explorer provider with progress UI. |
| packages/vscode-extension/src/providers/authenticationProvider.types.ts | Moves authentication session/claims types under providers/. |
| packages/vscode-extension/src/providers/authenticationProvider.ts | Moves authentication provider implementation under providers/. |
| packages/vscode-extension/src/extension.ts | Wires up source control registration and passes SCM service into commands/script service. |
| packages/vscode-extension/src/data.ts | Removes unused sample data/constants. |
| packages/vscode-extension/src/contributes/views.ts | Updates view registration imports to point to providers/. |
| packages/vscode-extension/src/contributes/sourceControl.ts | Registers the SCM content provider + SCM service during activation. |
| packages/vscode-extension/src/contributes/extraTablesTreeDataProvider.ts | Removes old extra tables provider from contributes/ (moved to providers/). |
| packages/vscode-extension/src/contributes/commands.ts | Adds SCM commands (discard/open), removes greeting logic, updates imports. |
| packages/vscode-extension/src/contributes/authenticationProvider.ts | Refactors contribute layer to register the provider from providers/. |
| packages/vscode-extension/package.json | Contributes SCM commands/menus and updates view visibility conditions. |
| .vscode/settings.json | Reformats cSpell words list and adds additional entries. |
packages/vscode-extension/src/providers/authenticationProvider.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ing/superoffice-tools into feature/ef/source-control
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.