Skip to content

port: vitest rename and CodeQL upgrade from master#409

Merged
killagu merged 3 commits intoeggjs:nextfrom
killagu-claw:port/vitest-and-codeql
Feb 19, 2026
Merged

port: vitest rename and CodeQL upgrade from master#409
killagu merged 3 commits intoeggjs:nextfrom
killagu-claw:port/vitest-and-codeql

Conversation

@killagu-claw
Copy link
Contributor

Summary

Changes

core/vitest (renamed from core/vitest-adapter):

  • Use Promise.race for error handling in createHeldScope to avoid hanging on init failure
  • Add watch mode support (clear stale state on re-collection)
  • Fix optional options parameter in onBeforeTryTask
  • Update debug env var to DEBUG_TEGG_VITEST

CodeQL workflow:

  • actions/checkout v3 → v4
  • github/codeql-action/* v2 → v3

Test plan

  • CI passes on next branch
  • vitest adapter tests pass with renamed package

🤖 Generated with Claude Code

cherry-pick from master c146105

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @killagu-claw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project by renaming the core/vitest-adapter package to core/vitest and incorporating several code improvements for the Vitest adapter, enhancing its robustness and developer experience. Additionally, it updates critical CI/CD dependencies by upgrading GitHub Actions for CodeQL and checkout to their latest major versions, ensuring better security and compatibility for the build pipeline.

Highlights

  • Package Renaming: The core/vitest-adapter package has been renamed to core/vitest, including its npm package name (@eggjs/tegg-vitest-adapter to @eggjs/tegg-vitest) and all related file paths.
  • Vitest Adapter Improvements: Error handling in createHeldScope now uses Promise.race to prevent hangs if beginModuleScope fails. Watch mode support was added to clear stale state during re-collection. The options parameter in onBeforeTryTask was made optional. The debug environment variable was updated from DEBUG_TEGG_VITEST_ADAPTER to DEBUG_TEGG_VITEST.
  • CI/CD Workflow Upgrades: The CodeQL Action was upgraded from v2 to v3, and actions/checkout was upgraded from v3 to v4 in the CI workflow.
Changelog
  • core/vitest/package.json
    • Renamed package name to @eggjs/tegg-vitest and updated associated paths.
  • core/vitest/src/index.ts
    • Implemented Promise.race for improved error handling in createHeldScope to prevent hanging on initialization failures.
  • core/vitest/src/runner.ts
    • Added watch mode support by clearing stale state during file re-collection.
    • Made options parameter optional in onBeforeTryTask.
    • Updated debug log messages and removed redundant comments.
  • core/vitest/src/shared.ts
    • Updated the debug environment variable name and log prefix.
  • core/vitest/test/fixtures/apps/demo-app/package.json
    • Updated the description to reflect the package rename.
  • vitest.config.ts
    • Updated test exclude path to reflect the renamed Vitest package.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/codeql-analysis.yml
Activity
  • The pull request was generated using Claude Code, indicating an automated creation process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@socket-security
Copy link

socket-security bot commented Feb 19, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedhusky@​9.1.71001006280100
Addedeventsource@​3.0.710010010085100
Addedglobby@​14.1.010010010089100

View full report

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily handles the renaming of the vitest-adapter package to vitest, along with several code improvements and a CodeQL workflow upgrade. The changes are well-described and mostly straightforward. The use of Promise.race for better error handling is a great addition. I've made one suggestion regarding the onBeforeTryTask method signature in core/vitest/src/runner.ts to improve code clarity and maintainability. Overall, this is a solid update.

eggjs#401)

- Rename package from @eggjs/tegg-vitest-adapter to @eggjs/tegg-vitest
- Use Promise.race for error handling in createHeldScope
- Add watch mode support (clear stale state on re-collection)
- Fix optional options parameter in onBeforeTryTask
- Update debug env var to DEBUG_TEGG_VITEST

cherry-pick from master c853090

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@killagu-claw killagu-claw force-pushed the port/vitest-and-codeql branch from 180842e to cbef0f1 Compare February 19, 2026 07:03
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.71%. Comparing base (1e75cae) to head (a87e640).
⚠️ Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #409   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files         314      314           
  Lines        9568     9568           
  Branches     1554     1504   -50     
=======================================
  Hits         8106     8106           
  Misses       1460     1460           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 973807c into eggjs:next Feb 19, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants