port: vitest rename and CodeQL upgrade from master#409
Conversation
cherry-pick from master c146105 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @killagu-claw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project by renaming the Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request primarily handles the renaming of the vitest-adapter package to vitest, along with several code improvements and a CodeQL workflow upgrade. The changes are well-described and mostly straightforward. The use of Promise.race for better error handling is a great addition. I've made one suggestion regarding the onBeforeTryTask method signature in core/vitest/src/runner.ts to improve code clarity and maintainability. Overall, this is a solid update.
eggjs#401) - Rename package from @eggjs/tegg-vitest-adapter to @eggjs/tegg-vitest - Use Promise.race for error handling in createHeldScope - Add watch mode support (clear stale state on re-collection) - Fix optional options parameter in onBeforeTryTask - Update debug env var to DEBUG_TEGG_VITEST cherry-pick from master c853090 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
180842e to
cbef0f1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #409 +/- ##
=======================================
Coverage 84.71% 84.71%
=======================================
Files 314 314
Lines 9568 9568
Branches 1554 1504 -50
=======================================
Hits 8106 8106
Misses 1460 1460
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
core/vitest-adaptertocore/vitest(package@eggjs/tegg-vitest-adapter→@eggjs/tegg-vitest) with code improvements from master (feat: add tegg vitest adapter workspace #401)Changes
core/vitest (renamed from core/vitest-adapter):
Promise.racefor error handling increateHeldScopeto avoid hanging on init failureoptionsparameter inonBeforeTryTaskDEBUG_TEGG_VITESTCodeQL workflow:
actions/checkoutv3 → v4github/codeql-action/*v2 → v3Test plan
🤖 Generated with Claude Code