Skip to content

Comments

[1949] Allow redefining a PartUsage with the same name#2008

Merged
AxelRICHARD merged 1 commit intomainfrom
pcd/fix/redefinition-name-resolution
Feb 20, 2026
Merged

[1949] Allow redefining a PartUsage with the same name#2008
AxelRICHARD merged 1 commit intomainfrom
pcd/fix/redefinition-name-resolution

Conversation

@pcdavid
Copy link
Contributor

@pcdavid pcdavid commented Feb 17, 2026 •
edited
Loading

Bug: #1949
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@pcdavid pcdavid force-pushed the pcd/fix/redefinition-name-resolution branch 3 times, most recently from de92bea to b0a29af Compare February 18, 2026 16:15
@pcdavid pcdavid added this to the 2026.3.0 milestone Feb 18, 2026
@pcdavid pcdavid linked an issue Feb 18, 2026 that may be closed by this pull request
Unable to redefine a PartUsage with the same name #1949
Closed
@pcdavid pcdavid force-pushed the pcd/fix/redefinition-name-resolution branch from b0a29af to 4169d20 Compare February 18, 2026 16:19
@pcdavid pcdavid marked this pull request as ready for review February 18, 2026 16:19
AxelRICHARD
AxelRICHARD reviewed Feb 19, 2026
View reviewed changes
@pcdavid pcdavid force-pushed the pcd/fix/redefinition-name-resolution branch from 4169d20 to e942d37 Compare February 20, 2026 10:08
AxelRICHARD
AxelRICHARD reviewed Feb 20, 2026
View reviewed changes
.../java/org/eclipse/syson/application/controllers/diagrams/general/view/GVDirectEditTests.java Outdated
.consumeNextWith(updatedDiagramContentMatcherBefore)
.then(redefinedElementsChecker)
.thenCancel()
.verify(Duration.ofSeconds(10_000));
Copy link
Member

@AxelRICHARD AxelRICHARD Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10_000 => 10

@AxelRICHARD
Copy link
Member

AxelRICHARD commented Feb 20, 2026

@pcdavid I will fix the small remark myself, rebase and merge the PR, thank you!

@AxelRICHARD AxelRICHARD force-pushed the pcd/fix/redefinition-name-resolution branch from e942d37 to ed975d0 Compare February 20, 2026 17:00
@pcdavid @AxelRICHARD
[1949] Allow redefining a PartUsage with the same name
a6f5bdb 
Bug: #1949
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@AxelRICHARD AxelRICHARD force-pushed the pcd/fix/redefinition-name-resolution branch from ed975d0 to a6f5bdb Compare February 20, 2026 17:01
@AxelRICHARD AxelRICHARD merged commit 96db030 into main Feb 20, 2026
4 checks passed
@AxelRICHARD AxelRICHARD deleted the pcd/fix/redefinition-name-resolution branch February 20, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD approved these changes

Assignees

No one assigned

Labels

pr: to review soon priority: low

Projects

None yet

Milestone

2026.3.0

Development

Successfully merging this pull request may close these issues.

Unable to redefine a PartUsage with the same name

2 participants

@pcdavid @AxelRICHARD