[1998] Add Implicit TypeFeaturing#2000
Open
adaussy wants to merge 1 commit intoeclipse-syson:mainfrom
Open
Conversation
Bug: eclipse-syson#1998 Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
adaussy
force-pushed
the
ada/fix/i1998
branch
from
b7d8db3 to
d6f63e1
Compare
AxelRICHARD
reviewed
Feb 17, 2026
| implicitType.setDeclaredName(owningType.getDeclaredName() + "-SNAPSHOT"); | ||
|
|
||
| // This virtual type should at some point redefine Occurrences::Occurrence::snapshots | ||
|
|
| implicitType = SysmlFactory.eINSTANCE.createFeature(); | ||
| implicitType.setDeclaredName(owningType.getDeclaredName() + "-SNAPSHOT"); | ||
|
|
||
| // This virtual type should at some point redefine Occurrences::Occurrence::snapshots |
Member
There was a problem hiding this comment.
And where it is done? (note @gcoutable is working on an issue that is related to Occurrences::Occurrence::snapshots)
| // isVariable = true. The checkFeatureFeatureMembershipTypeFeaturing constraint requires that such | ||
| // variable Features are featured by the snapshots of their owningType. | ||
| implicitType = SysmlFactory.eINSTANCE.createFeature(); | ||
| implicitType.setDeclaredName(owningType.getDeclaredName() + "-SNAPSHOT"); |
Member
There was a problem hiding this comment.
Is "-SNAPSHOT" arbitrary suffix? If it is, could you please just mention it?
| // KerML 7.3.2.6 “Feature Membership” – “A feature that is declared within the body of a type … automatically has that type as a featuring type.” | ||
| implicitType = owningType; | ||
| } else { | ||
| // KerML 8.4.4.3 |
Member
There was a problem hiding this comment.
This comment seems not related with the code below.
|
|
||
| * In _Validation_ view: | ||
|
|
||
| ** Improve the computation to _featuringType_ on `Feature` to avoid getting the following validation error: |
Member
There was a problem hiding this comment.
computation to => computation of
| For example `ViewUsage` elements are no longer rendered in _parts_ compartments. | ||
| - https://github.com/eclipse-syson/syson/issues/1981[#1981] [export] Fix an error during textual export where `Expose` elements with apostrophes in their name were not properly escaped. | ||
| - https://github.com/eclipse-syson/syson/issues/1983[#1983] [metamodel] `reqId` and `declaredShortName` properties of `RequirementDefinition` and `RequirementUsage` are now synchronized, as required by the SysMLv2 specification. | ||
| - https://github.com/eclipse-syson/syson/issues/1998[#1998] Missing implicit TypeFeaturing. |
Member
There was a problem hiding this comment.
missing category (please add one each time, you regularly forget to add one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #1998
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests