Skip to content

Comments

[1994] Add support for excluding standard libraries in search view#1997

Open
gdaniel wants to merge 1 commit intomainfrom
gda/enh/handleStandardLibrariesInSearchService
Open

[1994] Add support for excluding standard libraries in search view#1997
gdaniel wants to merge 1 commit intomainfrom
gda/enh/handleStandardLibrariesInSearchService

Conversation

@gdaniel
Copy link
Contributor

@gdaniel gdaniel commented Feb 13, 2026

Bug: #1994

Fixes #1994

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gdaniel
Copy link
Contributor Author

gdaniel commented Feb 13, 2026

To finish once 2026.1.3 is available in SysON

Bug: #1994
Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
@gdaniel gdaniel force-pushed the gda/enh/handleStandardLibrariesInSearchService branch from 86de3c8 to c5e2f1f Compare February 19, 2026 15:32
@gdaniel gdaniel marked this pull request as ready for review February 19, 2026 15:34
assertThat(matches).containsExactly("parts");
}

private List<String> search(String editingContextId, String text, boolean matchCase, boolean matchWholeWord, boolean useRegularExpressions, boolean searchInAttributes, boolean searchInLibraries) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is copied from the Sirius Web's SearchIntegrationTests.
It is a bit overkill at the moment (some parameters always have the same values with the current tests), but it will be quite helpful if we want to test other search configurations in the future.

Let me know if I should reduce the number of parameters to the ones we currently use (and add new ones later if needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for excluding libraries in the search view

1 participant