fix: allow root execution in container/sandbox/CI environments#9
Merged
fix: allow root execution in container/sandbox/CI environments#9
Conversation
Previously, blade unconditionally blocked any root user (uid === 0), which prevented running in Docker containers, CI pipelines, and sandbox environments where root is the default user. Now we distinguish between: - sudo escalation (SUDO_USER set) → still blocked for safety - native root (containers/CI) → allowed Added BLADE_ALLOW_ROOT=1 escape hatch for edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
blade unconditionally blocks any root user (uid === 0), preventing execution in:
Root Cause
blade.tsxline 43 checksprocess.getuid() === 0and exits immediately, without distinguishing betweensudoescalation and native root environments.Solution
Distinguish between:
SUDO_USERsudo bladeBLADE_ALLOW_ROOT=1 sudo bladeAlso detects container environments via
container,DOCKER_CONTAINER,KUBERNETES_SERVICE_HOST, andCIenv vars.Changes
packages/cli/src/blade.tsx: Refined root detection logic inmain()Testing