Enhancement/Sum constraints on NumberNode by fastbodin · Pull Request #471 · dwavesystems/dwave-optimization

fastbodin · 2026-01-30T22:42:05Z

Do not merge. Draft PR. ~~Only C++ has been implemented.~~ Simply checking CircleCi.

fastbodin · 2026-02-03T23:45:52Z

Feature is fully implemented.

fastbodin · 2026-02-04T20:32:33Z

Closes #216.

dwave/optimization/include/dwave-optimization/nodes/numbers.hpp

dwave/optimization/libcpp/nodes/numbers.pxd

dwave/optimization/symbols/numbers.pyx

dwave/optimization/model.py

dwave/optimization/src/nodes/numbers.cpp

dwave/optimization/include/dwave-optimization/nodes/numbers.hpp

fastbodin · 2026-02-05T00:53:48Z

First round of comments addressed.

dwave/optimization/symbols/numbers.pyx

wbernoudy · 2026-02-05T22:12:11Z

I do see "hyperslice" used in a lot of comments. Would prefer that is changed to just "slice" as well, or at least a small comment maybe in the header numbers.hpp on what that term means here.

dwave/optimization/src/nodes/numbers.cpp

tests/test_symbols.py

fastbodin · 2026-02-06T02:07:44Z

Second round of comments addressed.

arcondello

Looks great! Just two aesthetic comments

dwave/optimization/include/dwave-optimization/nodes/numbers.hpp

dwave/optimization/src/nodes/numbers.cpp

fastbodin · 2026-02-06T22:34:43Z

Third round of comments addressed.

dwave/optimization/src/nodes/numbers.cpp

Data is stored at C++ level with the class `AxisBoundInfo` as private attribute to `NumberNode`. Added relevant C++ tests.

For each bound axis and each hyperslice along said axis, we store the running sum of the values within the hyperslice. This state dependant data is stored via `NumberNodeStateData`. If `NumberNode` is initialized with values, we check that all axis-wise bounds are satisfied.

Added satisfies_axis_wise_bounds(), update_bound_axis_slice_sums(), axis_wise_bounds(), and bound_axis_sums() to NumberNode. Updated various NumberNode, IntegerNode, and BinaryNode methods to reference NumberNodeStateData as opposed to ArrayNodeStateData. Updated all NumberNode mutate methods to reflect changes to the axis-wise bound running sums. Added C++ tests to check said mutate methods on BinaryNode and IntegerNode.

Make use of BufferIterators to compute the sum of the values within each hyperslice along each bound axis as opposed making a custom method to do this.

`BoundAxisInfo` -> `AxisBound` and `BoundAxisOperator` -> `Operator`. `Operator` is now a nested enum classs of `AxisBound`.

Added indicator variable that all bound axis operators are `==` to reduce redundancy in `NumberNode::exchange()` method.

Made axis, operators, and bounds private members. Added axis(), num_bounds(), and num_operators() methods. Updated C++ code/tests, Python, and Cython to reflect this.

Removed `asserts()` that axis-wise bounds were satisfied to `NumberNode::propagate()`.

dwave/optimization/symbols/numbers.pyx

Added a `const` to `State& state`. Fixed typos.

Previously, users could not define a bound for the sum of the values over an entire `NumberNode` array. This lead to the undesired behaviour that users could not define a bound on the sum of the values in a `NumberNode` vector.

fastbodin · 2026-02-27T20:57:53Z

Previously, users could not define a bound for the sum of the values over an entire NumberNode array. This lead to the undesired behaviour that users could not define a bound on the sum of the values in a NumberNode vector.

Users may now define a bound on the sum of the values in the entire `NumberNode` array.

dwave/optimization/symbols/numbers.pyx

dwave/optimization/src/nodes/numbers.cpp

dwave/optimization/model.py

In previous commits, we expanded the functionality of `NumberNode` such that a user may define implicit constraints on the sum of values within the node. We allow constraints on the entire array and along a fixed axis. The naming convention axis-wise bounds was given before we allowed constraints over the entire array. In the latter case, there is no `axis`. Changing naming convention to `sum constraints`.

See prior commit message.

fastbodin · 2026-03-06T23:24:26Z

Changed naming convention to reflect that this features is really a summation constraint that is either applied to the entire array or to each slice along an axis.

dwave/optimization/libcpp/nodes/numbers.pxd

Naming convention change to methods, variables, and comments.

fastbodin force-pushed the enhancement/axis_wise_bounds_numbernode branch 2 times, most recently from bebd145 to 15f7b67 Compare February 3, 2026 23:11

fastbodin force-pushed the enhancement/axis_wise_bounds_numbernode branch from e3b0255 to 1c177b4 Compare February 4, 2026 00:02

fastbodin marked this pull request as ready for review February 4, 2026 20:24

arcondello linked an issue Feb 4, 2026 that may be closed by this pull request

Consider adding the ability to specify one axis bound to BinaryVariable #216

Open

arcondello reviewed Feb 4, 2026

View reviewed changes

dwave/optimization/include/dwave-optimization/nodes/numbers.hpp Outdated Show resolved Hide resolved

arcondello requested a review from wbernoudy February 4, 2026 22:49

arcondello added the enhancement New feature or request label Feb 4, 2026

wbernoudy reviewed Feb 4, 2026

View reviewed changes

fastbodin force-pushed the enhancement/axis_wise_bounds_numbernode branch from 4b2205c to c6a93d5 Compare February 5, 2026 06:37