Add http://noveldex.io/ parser (#2471)#2546
Open
nitramkh wants to merge 1 commit intodteviot:ExperimentalTabModefrom
Open
Add http://noveldex.io/ parser (#2471)#2546nitramkh wants to merge 1 commit intodteviot:ExperimentalTabModefrom
nitramkh wants to merge 1 commit intodteviot:ExperimentalTabModefrom
Conversation
dteviot
reviewed
Mar 18, 2026
dteviot
reviewed
Mar 18, 2026
plugin/js/parsers/NoveldexParser.js
Outdated
| * | ||
| * @type { NodeListOf<HTMLAnchorElement> } | ||
| */ | ||
| let chapterLinksElements = dom.querySelectorAll(`div[id] div[data-state] a[href*="chapter"]:not(:has(svg.lucide-lock))`); // eslint-disable-line quotes |
dteviot
reviewed
Mar 18, 2026
dteviot
requested changes
Mar 18, 2026
nitramkh
force-pushed
the
feature/add_noveldex_io_parser
branch
from
ba6e808 to
be3661f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2471.
This should be a mostly good parser for http://noveldex.io/, there are some improvements which can be made but I think it's sufficient for people who want to try using it rather than continuing to wait.
A list of things which may be of note in no particular order:
The CSS selectors used look a bit odd, since I've been busy I started on this 2 weeks ago and in that time I've seen three separate occurrences of change wherein either ids and classes were changed. But I observed no structural HTML changes, so I went for that instead.
The location of the chapter names are inconsistently placed, there is an "official" location for the chapter titles; but many stories seem to just chuck them in the content in a non-standardized way. So it just ignores these for now, but I may fix that later if someone cares.
This seems to primarily be a translation site and I've included the translators as an author. However, again many individual chapters seem to have the translator listed in a non-standardized way inside the chapter content. I ignored this as I couldn't see an obvious way to modify the author field after fetching the chapter contents; and didn't think a hacky implementation would be appreciated ;)
I didn't test this too deeply as I don't use the site myself, but I did download a couple stories using Chrome and Firefox, including the dev-tools mobile view thing; and skimmed the contents and it looked alright. But frankly, I figure if it doesn't work the requesters will let me know and I actually have time to fix it in a timely manner now.
I added automatic skipping of locked chapters which works fine. But I can't test if unlocking and downloading these chapters actually works. But I saw no harm in including it, with the hope that one of the requesters can test it; and if broken I can fix it or remove it.
As always, if there are any issues or even thing anything you just don't like, I'm happy to fix it ;)
Pull request checklist