Skip to content

Update FalooParser#2545

Merged
dteviot merged 3 commits intodteviot:ExperimentalTabModefrom
Yomafil:Update-FalooParser
Mar 18, 2026
Merged

Update FalooParser#2545
dteviot merged 3 commits intodteviot:ExperimentalTabModefrom
Yomafil:Update-FalooParser

Conversation

@Yomafil
Copy link
Collaborator

@Yomafil Yomafil commented Mar 17, 2026

Updated the FalooParser to now list all VIP chapters, but leave them unchecked by default.
Also, use the table of content to get the chapters, and get the non-truncated title of a chapter from it.

chapters.push({
sourceUrl: link.href,
title: title,
isIncludeable: !isVipReached
Copy link
Owner

@dteviot dteviot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line

isIncludeable: !isVipReached

Suggests you want to include all chapters, but mark the VIP chapters as disabled.
The "continue" line I commented on previously means the VIP chapters will be excluded from the chapter list.
Which of the two are you trying to do?

You should remove one of the continue or the isIncludeable lines.

@Yomafil
Copy link
Collaborator Author

Yomafil commented Mar 18, 2026

Changed how we check for VIP chapters, we now look at how a chapter element is stored inside div.c_con_list, and not just assuming that everything is VIP after hitting a single header.
If an element is c_con_li_detail, it's a VIP chapter.

It should be better now.
Haven't yet found a book that has a free volume, then a VIP one, and then another free one, so I couldn't test this case.
But it should be handled by this new way of checking for VIP.

@dteviot dteviot merged commit 5963a59 into dteviot:ExperimentalTabMode Mar 18, 2026
1 check passed
@dteviot
Copy link
Owner

dteviot commented Mar 18, 2026

@Yomafil
Thank you for your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants