Add xbanxia.cc parser support#2536
Merged
dteviot merged 1 commit intodteviot:ExperimentalTabModefrom Mar 12, 2026
Merged
Conversation
Owner
|
Thank you very much for your contribution. Note, generally, I only bother to add unit tests for code that needs to do "complicated" logic. For example, for this parser, I'd only bother to add a unit test for the extractSubject() function. The rest of the functions are so simple that just running WebToEpub against a web page and then checking the UI (and the generated Epub) is usually sufficient. That said, it would be nice if you included the URLs of the Table of Contents and a couple of chapters you tested the parser against, (Mostly if someone says "It's broken", then we have something to go back to, to look for breakages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add first-class parser support for \xbanxia.cc\.
This adds a dedicated \XbanxiaParser\ for:
It also updates the contributor checklist items by adding \s4daharu\ to \package.json\ and the Credits section in \
eadme.md\.
Validation
pm run lint\ passes
Notes
The full \unitTest/Tests.html\ suite still shows 6 unrelated pre-existing \DOMPurify is not defined\ failures in existing tests. This PR is intentionally scoped to \xbanxia.cc\ parser support plus the contribution-guide credit updates.