enable building stochastic_physics using CMake#3
enable building stochastic_physics using CMake#3guoqing-noaa wants to merge 8 commits intodtcenter:gsl/MPAS_stoch_physicsfrom
Conversation
|
Note: it is better to merge this PR dtcenter/stochastic_physics#3 first. |
|
I ran several 3km conus tests on hera and ursa using the code in Guoqing's PRs and using the "build.sh" script as-is, meaning the build was with cmake. Each test requested 1200 cores (ursa therefore ended up being partially undersubscribed). This was the result: -Hera, sppt on, spptint=0, dt=15, succeeded through 36h forecast -Ursa, nosppt, dt=15, succeeded through 36h forecast -Hera, Nosppt, dt=15, succeeded through 36h forecast -Hera, sppt on, spptint=600, dt=15, failed after 1hr, 23m. Repeated this test 3 times and all failed at the same moment, no clue as to why. -hera, sppt on, spptint=600, dt=10, failed after 35hr, 9m forecast for job time limit reached /scratch4/BMC/wrfruc/mayfield/mpas_stoch/cost_tests/expt_dirs/stoch_cost/conus_3km/mpas_atm_spptint600_cmake_hera -Ursa, sppt on, spptint=600, dt=15, failed after 30h 9m 15s forecast, for “cancelled for time limit”…. However, it reached the point that it forecasted to well within the time limit (in fact, timesteps were progressing 20-30% faster than the same test on hera), and then appeared to hang for the remainder of the requested time.... seems like this may be the random node drops others have been seeing? I feel satisfied from these that any issues are not related to Guoqing's code or the cmake build. @gsketefian @NingWang325 @JeffBeck-NOAA Is there any reason to wait for Ning's PR, or are we ready to merge this? |
|
@willmayfield, thanks for doing this extensive testing! Did you try rerunning spptint=600 on Ursa with dt=15 or try dt=10 to see if the hanging resolved? It does sound like a specific HPC issue and unrelated to the code. I'm comfortable merging these changes as is. |
|
@willmayfield Thank you very much for lots of testing! It is known that MPAS-Model may hang on Ursa (This exists before the stochastic physics work). Also, we can test it on gaea if possible. With that said, I agree with you and @JeffBeck-NOAA that the issue is NOT related to this PR. Thanks! |
|
@willmayfield For model hangs on Ursa, please add the following line to your job card: It was just suggested by Ursa Admin and it did solve one of my model hangs. |
This PR enable building stochastic_physics using CMake.
core_atmosphere/CMakeLists.txtto build stochastic_physics as a module for MPAS-Modelstochastic_physicsto usempiinstead ofmpi_f08as the default MPAS-Model compiles withmpi.This is the first step to make the stochastic compiling successfully using CMake. Future PR will introduce
#ifdef MPAS_USE_MPI_F08as has been done in MPAS-Model.fmslibrary and this capability may be added in future PRs (so,halo_exchange.fv3.F90, cellular_automata_global.F90, cellular_automata_sgs.F90, update_ca.F90are excluded in CMakeLists.txt for now).CCPP_32BITis defined. The parent MPAS-Model sets this or not depending on whether to build with double precision.core_atmosphere/stochastic_physics/CMakeLists.txtis NOT used by the parent MPAS-Model. So any changes in that file will not affect the MPAS-Model. This is consistent with the current MPAS-Model practice.If needed, a
-DSTOCHASTIC_PHYSICS=ONoption may be added to turn on/off the building of stochastic_physics in a future PR.