Add the ability to add debugging notes to the result.safe decorator.

[madkopp]

Add the ability to add debugging notes to the result.safe decorator.

Checklist

• I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
• I have created at least one test case for the changes I have made
• I have updated the documentation for the changes I have made
• I have added my changes to the CHANGELOG.md

Related issues

-Refs #2107, but may not fully close it. The need to provide a list of Exceptions in order to use the add_note_on_failure keyword is a little clunky.
number

Would appreciate any help with the overloading of the safe decorator to alleviate the need to provide a list of Exceptions.

I wasn't exactly sure how you wanted me to add the changes to the change log, so I just made a "Features" section at the top of the list that isn't attached to any version. (I wasn't sure if you wanted me to go creating version numbers on your behalf or not).

Thanks for the great package!

🙏 Please, if you or your company finds dry-python valuable, help us sustain the project by sponsoring it transparently on https://github.com/sponsors/dry-python. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

[sobolevn]

Generally looks good, but there are several things to add:

• impure_safe and future_safe should be updated as well
• Please, add a typesafety test for this
• Test an empty string

Thank you!

[madkopp]

Generally looks good, but there are several things to add:

• impure_safe and future_safe should be updated as well
• Please, add a typesafety test for this
• Test an empty string

Thank you!

Thanks for the comments! I've updated the pull request to reflect the changes. Let me know if anything needs tweaking.

[sobolevn]

Thanks! Just two minor comments :)

[madkopp]

Ok pushed changes. Let me know if that addresses things.

[madkopp]

FYI, I was looking at the code for the Result container and noticed that there's a trace property that it looks like you intend to implement at some point. If the plan is for that to carry the traceback of any errors, that could make this PR unnecessary, depending on how it's done.

[sobolevn]

Yes, tracing is implemented.