feat: prepend breadcrumb comment to all SQL queries (DX-117497)#9
Open
aniket-s-kulkarni wants to merge 1 commit intodremio:mainfrom
Open
feat: prepend breadcrumb comment to all SQL queries (DX-117497)#9aniket-s-kulkarni wants to merge 1 commit intodremio:mainfrom
aniket-s-kulkarni wants to merge 1 commit intodremio:mainfrom
Conversation
All SQL submitted through dremio-cli now carries a leading comment: /* dremio-cli: submitter=cli */ <user SQL> This enables backend query attribution — the Jobs service can detect queries originating from the CLI, consistent with how dremio-mcp uses /* dremioai: submitter=agent */. The breadcrumb is added in the single submit_sql() method in client.py, so every command that runs SQL (query, job, schema, folder, reflection) gets it automatically. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isha-dremio
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dremio-clinow carries a leading breadcrumb comment:/* dremio-cli: submitter=cli */ <user SQL>dremio-mcpuses/* dremioai: submitter=agent */submit_sql()method inclient.py, so every command that runs SQL (query, job, schema, folder, reflection) gets it automaticallyTest plan
test_client.pyverify breadcrumb is prepended (with and without context)dremio query run "SELECT 1"against Dremio Cloud and verify the breadcrumb appears in the job's SQL viasys.project.history.jobsJIRA: DX-117497
🤖 Generated with Claude Code