test: normalize trailing newlines in TestDecryptVariousChainhashes to avoid platform differences#91
Merged
AnomalRoil merged 1 commit intodrand:mainfrom Sep 10, 2025
Conversation
… avoid platform differences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes a flaky test by trimming trailing CR/LF from both the decrypted bytes and the expected
loremBytesbefore comparison. This prevents a 1-byte mismatch caused by platform-dependent line endings.Rationale
\r\nvs\n, causing the test to fail with lengths 1063 vs 1064.Changes
TestDecryptVariousChainhashesintlock_test.goto:\rand\nfrom both byte slices prior to equality check.Scope
Testing
go test ./...locally; all packages pass.Risks
Notes
go.mod/go.sumchurn.