Make sure thumbnails work when images are on S3#34
Open
egyptianbman wants to merge 1 commit intodphiffer:masterfrom
Open
Make sure thumbnails work when images are on S3#34egyptianbman wants to merge 1 commit intodphiffer:masterfrom
egyptianbman wants to merge 1 commit intodphiffer:masterfrom
Conversation
Copied from q-m/wp-json-api@ff9ffe1 -- I would have preferred to create a PR with his commit but he didn't for this repo so I had to re-create the change. This commit is necessary for us to implement an api while using an S3 plugin that pushes all images to S3. The actual files don't exist locally so without this change, we get an empty array and the only available `url` is one that's local and is not valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from q-m/wp-json-api@ff9ffe1 -- I would have preferred to create a PR with his commit but he didn't fork this repo so I had to re-create the change. This commit is necessary for us to implement an api while using an S3 plugin that pushes all images to S3. The actual files don't exist locally so without this change, we get an empty array and the only available
urlis one that's local and is not valid.