Skip to content

Fix/403 err agent#79

Open
rubengmurray wants to merge 7 commits intodopecodez:masterfrom
rubengmurray:fix/403-err-agent
Open

Fix/403 err agent#79
rubengmurray wants to merge 7 commits intodopecodez:masterfrom
rubengmurray:fix/403-err-agent

Conversation

@rubengmurray
Copy link
Copy Markdown

@rubengmurray rubengmurray commented Jan 1, 2026 •
edited
Loading

Fixes #77 & #78

This was referenced Jan 1, 2026
Open
Open
rubengmurray
rubengmurray commented Jan 1, 2026
View reviewed changes
test/pdf.test.ts
@@ -1,6 +1,5 @@
import * as request from '../source/request';
import wiki from "../source/index";
import { htmlString, notFoundJson } from './samples';
Copy link
Copy Markdown
Author

@rubengmurray rubengmurray Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

rubengmurray
rubengmurray commented Jan 1, 2026
View reviewed changes
source/request.ts
async function callAPI(url: string) {
const options: AxiosRequestConfig = {
headers: {
"User-Agent": USER_AGENT,
Copy link
Copy Markdown
Author

@rubengmurray rubengmurray Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #77 & #78

@kierandrewett
Copy link
Copy Markdown

kierandrewett commented Mar 18, 2026

@dopecodez any chance this can get reviewed?

@dopecodez
Copy link
Copy Markdown
Owner

dopecodez commented Mar 20, 2026

The changes look good, but why so many changes in your yarn.lock? are we using any new packages or is this is an unwanted change?

@rubengmurray
Copy link
Copy Markdown
Author

rubengmurray commented Mar 30, 2026

Yes, unintentional @dopecodez I've reverted those now.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2e84045) to head (4d1db5f).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          647       647           
  Branches        69        69           
=========================================
  Hits           647       647

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dopecodez
Copy link
Copy Markdown
Owner

dopecodez commented Apr 7, 2026

Code looks good and all the workflows are passing, ill merge and put out a new version of wikipedia this weekend. Thanks for the MR @rubengmurray 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search Not working

4 participants

@rubengmurray @kierandrewett @dopecodez @codecov-commenter