Skip to content

Split VF and Match Functions#126

Merged
kiwi515 merged 12 commits intodoldecomp:masterfrom
Alex9303:VF
Apr 5, 2026
Merged

Split VF and Match Functions#126
kiwi515 merged 12 commits intodoldecomp:masterfrom
Alex9303:VF

Conversation

@Alex9303
Copy link
Copy Markdown
Contributor

This pr splits the VF section to the best of my ability.
I also matched some functions.

@Alex9303 Alex9303 marked this pull request as draft February 28, 2026 14:30
@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Mar 1, 2026

Report for RSPE01_01 (9f91f44 - 36e8747)

📈 Matched code: 32.44% (+3.32%, +115372 bytes)
📈 Linked code: 27.18% (+2.03%, +70452 bytes)
📈 Matched data: 37.48% (+10.89%, +165296 bytes)
📈 Linked data: 53.78% (+11.02%, +167352 bytes)

✅ 414 new matches
Unit Item Bytes Before After
main/revolution/VF/pf_volume .bss +163768 0.00% 100.00%
main/revolution/VF/pf_entry_iterator VFiPFENT_ITER_DoFindEntry +2072 0.00% 100.00%
main/revolution/VF/pf_path VFiPFPATH_parseShortName +1864 0.00% 100.00%
main/revolution/VF/nand_drv _MountPrfFile +1632 0.00% 100.00%
main/revolution/VF/pdm_bpb VFipdm_bpb_get_bpb_information +1336 0.00% 100.00%
main/revolution/VF/pf_path VFiPFPATH_DoMatchFileNameWithPattern +1268 0.00% 100.00%
main/revolution/VF/pf_file VFiPFFILE_p_fopen +1264 0.00% 100.00%
main/revolution/VF/pf_volume VFiPFVOL_attach +1208 0.00% 100.00%
main/revolution/VF/pf_fat12 VFiPFFAT12_WriteFATEntryPage +1164 0.00% 100.00%
main/revolution/VF/pf_cache VFiPFCACHE_DoWriteNumSectorAndFreeIfNeeded +1032 0.00% 100.00%
main/revolution/VF/pf_file VFiPFFILE_Cursor_Write +912 0.00% 100.00%
main/revolution/VF/nand_drv A32_NANDRead +904 0.00% 100.00%
main/revolution/VF/pf_path VFiPFPATH_GetNextTokenOfPath +900 0.00% 100.00%
main/revolution/VF/pf_fat VFiPFFAT_FreeChain +896 0.00% 100.00%
main/revolution/VF/pf_file VFiPFFILE_fseek +884 0.00% 100.00%
main/revolution/VF/pf_entry VFiPFENT_searchEmptyTailSFN +880 0.00% 100.00%
main/revolution/VF/pf_path VFiPFPATH_cmpNameImpl +872 0.00% 100.00%
main/revolution/VF/pf_file VFiPFFILE_fclose +860 0.00% 100.00%
main/revolution/VF/pf_entry VFiPFENT_findEntryPos +844 0.00% 100.00%
main/revolution/VF/pf_entry_iterator VFiPFENT_ITER_Retreat +812 0.00% 100.00%
main/revolution/VF/pf_fat VFiPFFAT_GetClusterInChain +808 0.00% 100.00%
main/revolution/VF/pf_path VFiPFPATH_CheckExtShortName +804 0.00% 100.00%
main/revolution/VF/pf_entry_iterator VFiPFENT_ITER_FindCluster +800 0.00% 100.00%
main/revolution/VF/pf_entry VFiPFENT_allocateEntryPos +796 0.00% 100.00%
main/revolution/VF/pf_path VFiPFPATH_MatchFileNameWithPattern +796 0.00% 100.00%
main/revolution/VF/pf_file VFiPFFILE_createEmptyFile +788 0.00% 100.00%
main/revolution/VF/nand_drv VFi_NandFlushNANDFromHandleIdx +772 0.00% 100.00%
main/revolution/VF/pf_sector VFiPFSEC_ReadData +736 0.00% 100.00%
main/revolution/VF/pf_fat12 VFiPFFAT12_ReadFATEntryPage +724 0.00% 100.00%
main/revolution/VF/pf_file VFiPFFILE_Cursor_WriteTailSector +708 0.00% 100.00%

...and 384 more new matches

🥀 1 broken match
Unit Item Bytes Before After
main/Pack/RPSystem/RPSysSaveDataMgr .rodata -80 100.00% 0.93%
📈 11 improvements in unmatched items
Unit Item Bytes Before After
main/revolution/VF/pf_cp932 .rodata +17012 0.00% 99.98%
main/revolution/VF/pf_entry_iterator VFiPFENT_ITER_DoGetEntry +1558 0.00% 99.92%
main/revolution/VF/pdm_dskmng .bss +1460 0.00% 50.00%
main/revolution/VF/pf_cp932 VFiPFCODE_CP932_Unicode2OEM +607 0.00% 98.64%
main/revolution/VF/pf_cp932 VFiPFCODE_CP932_OEM2Unicode +433 0.00% 97.61%
main/revolution/VF/d_hash .bss +296 0.00% 51.39%
main/revolution/VF/pf_fat .rodata +61 0.00% 96.77%
main/revolution/VF/pf_entry_iterator .sdata +37 0.00% 93.33%
main/revolution/VF/pf_path .sdata +26 0.00% 55.67%
main/revolution/VF/d_vf_sys .sbss +20 0.00% 83.33%
main/revolution/VF/pf_filelock .sbss +4 0.00% 50.00%

@Alex9303 Alex9303 marked this pull request as ready for review March 30, 2026 04:15
@kiwi515 kiwi515 merged commit 6c21d6f into doldecomp:master Apr 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants