kubernetes: trim client-go dependency surface#3707
Open
tonistiigi wants to merge 3 commits intodocker:masterfrom
Open
kubernetes: trim client-go dependency surface#3707tonistiigi wants to merge 3 commits intodocker:masterfrom
tonistiigi wants to merge 3 commits intodocker:masterfrom
Conversation
Replace the full generated clientset and global Kubernetes scheme with a small local REST client layer and minimal scheme registration. This keeps the existing kubeconfig/auth and remote exec behavior while significantly reducing the linked and vendored Kubernetes dependency set. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Use sync.OnceValue to initialize the kubeclient scheme, codec factory, and parameter codec as a single lazy-loaded bundle. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Drops the gogo-proto XXX_* methods. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
commented
Mar 7, 2026
| TTY: false, | ||
| }, scheme.ParameterCodec) | ||
| }, kubeclient.ParameterCodec()) | ||
| exec, err := remotecommand.NewSPDYExecutor(restConfig, "POST", req.URL()) |
Member
Author
There was a problem hiding this comment.
@AkihiroSuda Iiuc we could also replace this spdy dependency with kubernetes/enhancements#4006 . Seems that would require k8s 1.31+ . When do you think we could do that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the full generated clientset and global Kubernetes scheme with a small local REST client layer and minimal scheme registration.
This keeps the existing kubeconfig/auth and remote exec behavior while significantly reducing the linked and vendored Kubernetes dependency set.