Conversation
Member
|
@EricPei20 This looks good and I can merge it if you would like but before merging it would be good to clean up your git history. The proper way to handle this would be to squash all of the commits and then clean up the commit message. You'll have to force push to your branch but that it fine. In general force pushing to a personal branch is good, force pushing to the main branch is bad. Let me know if you want any help with that. But this can be squashed mostly into a single commit before merging and that helps if we need to look back at the history. |
… unnecessary line in get_result.
EricPei20
force-pushed
the
fix_win32event_failures
branch
from
1631d2a to
201d8ae
Compare
Contributor
Author
|
Hi @CSSFrancis, thanks for reviewing my code and for your suggestions. I squashed all of my commits into one, so feel free to merge this branch if it looks okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.