Open
Conversation
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Feb 5, 2026
hospexplorer/ask/llm_connector.py
Outdated
| settings.LLM_HOST + settings.LLM_QUERY_ENDPOINT, | ||
| json=payload, | ||
| headers=headers, | ||
| timeout=60 |
Member
There was a problem hiding this comment.
the timeout needs to be configurable (60 seconds might not be enough).
hospexplorer/ask/views.py
Outdated
| return JsonResponse({"error": f"Failed to connect to server: {e}"}, status=500) No newline at end of file | ||
| return render(request, "_response.html", {"message": content}) | ||
| except Exception: | ||
| return render(request, "_response.html", {"message": "Something went wrong. Please try again."}) No newline at end of file |
Member
There was a problem hiding this comment.
I don't think this is right, is it? Doesn't the api call from the frontend to the backend still wait for the server to respond? And if that takes too long, then the webserver might still time out. The frontend needs to poll the backend to see if the LLM has responded yet and if not then keep polling.
Member
|
Resolve conflicts please |
Member
|
Resolve conflicts please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
chat request from frontend needs to happen asynchronously
Description
otherwise the backend times out. so maybe some “thinking” feedback in the frontend while the request is made and being polled.
HOP-11
Are there any other pull requests that this one depends on?
Anything else the reviewer needs to know?
... describe here ...