Open
Conversation
RangerMauve
approved these changes
Oct 23, 2025
Member
Author
|
I modified the condition again so that the release job still runs on closed PRs (not just merged PRs), because the optic release bot will clean up the draft release that was created if the PR is closed. This avoids leaving draft releases around when releases are abandoned (by closing the PR). |
RangerMauve
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the release job condition wrong in my last PR. When this workflow runs as a result of a pull_request close,
github.event.inputs.semveris not set (it's only set by workflow_dispatch).All we can do is avoid creating the PR in the first place (which happens on the workflow_dispatch event) when it's a non-prerelease targeting a non-default branch, but if the PR is somehow created anyway (it shouldn't be) then the action would run regardless of which branch it's targeting when the PR is merged.
I think this is fine, this is just a safety check anyway.