fix: fix invalidation misses on members-related reads#171
Merged
Conversation
Member
Author
|
Part of me thinks that it's not even worth including this option as part of the query key since it could potentially lead to other similar issues due to how the query keys for member-specific reads works. Doing so would mean having to silence the relevant eslint rule about query key deps - there's currently only one line where that would need to be done. There isn't an issue now because none of the existing write hooks specify the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suspecting this is the cause of the issue with removing a remote archive highlighted in digidem/comapeo-mobile#1797.
Prior to this change, all of the write hooks related to the members API invalidate
['@comapeo', 'projects', someProjectId, 'members', { includeLeft: undefined }], which misses the cases where a read hook internally uses a query key whereincludeLeftis a boolean value e.g.['@comapeo', 'projects', someProjectId, 'members', { includeLeft: true }]or['@comapeo', 'projects', someProjectId, 'members', { includeLeft: false }].The proposed fix is to omit the last key fragment when
includeLeftis undefined or unspecified, so that the write hook invalidations match['@comapeo', 'projects', someProjectId, 'members'], which will cover all members-related reads.