chore: deprecate getLastAtom and add a test#159
Merged
sbillinge merged 1 commit intodiffpy:v3.4.0from Feb 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.4.0 #159 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 13 13
Lines 1905 1919 +14
=======================================
+ Hits 1885 1899 +14
Misses 20 20
🚀 New features to boost your workflow:
|
Contributor
|
This is perfect! Well, one thought, I am not sure why we are using Now things are going smoothly, I think that it is ok to put more than one of these on each PR if that is easier. But please, not more than 3 or 4 as they become confusing to review. Thanks so much for this @stevenhua0320 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review, note that there is no test for
getLastAtom, but it is only a getter function, I add a very simple function to test this. Now thepytestwould be shown like this: